Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ecs): add additional missing unit tests #3679

Merged
merged 4 commits into from
Aug 19, 2019
Merged

chore(ecs): add additional missing unit tests #3679

merged 4 commits into from
Aug 19, 2019

Conversation

iamhopaul123
Copy link
Contributor

Add missing unit tests for aws-ecs.

Please read the contribution guidelines and follow the pull-request checklist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@iamhopaul123 iamhopaul123 requested a review from piradeepk August 15, 2019 22:09
@NGL321 NGL321 added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Aug 15, 2019
@iamhopaul123 iamhopaul123 force-pushed the additional_missing_unit_test branch from 91650b9 to 48d1bbe Compare August 16, 2019 22:06
@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2019 •
edited by iamhopaul123
Loading

Pull Request Checklist

  • Testing
  • Unit test added (prefer to add a new test rather than modify existing tests)
  • CLI change? Re-run/add CLI integration tests
  • Documentation
  • Inline docs: make sure all public APIs are documented (copy & paste from official AWS docs)
  • README: update module README
  • Design: for significant features, follow the design process
  • Title uses the format type(scope): text
  • Type: fix, feat, refactor go into CHANGELOG, chore is hidden
  • Scope: name of the module without the aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
  • Style: use all lower-case, do not end with a period
  • Description
  • Rationale: describe rationale of change and approach taken
  • Issues: Indicate issues fixed via: fixes #xxx or closes #xxx
  • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Sensitive Modules (requires 2 PR approvers)
  • IAM document library (in @aws-cdk/aws-iam)
  • EC2 security groups and ACLs (in @aws-cdk/aws-ec2)
  • Grant APIs (if not based on official documentation with a reference)

@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

@aws aws deleted a comment from mergify bot Aug 17, 2019
@aws aws deleted a comment from mergify bot Aug 17, 2019
piradeepk
piradeepk previously requested changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@piradeepk piradeepk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! Just had a couple comments.

packages/@aws-cdk/aws-ecs/test/ec2/test.ec2-service.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/test/test.container-definition.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/test/test.container-definition.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/test/ec2/test.ec2-service.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/test/ec2/test.ec2-service.ts Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/test/ec2/test.ec2-service.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/test/ec2/test.ec2-service.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/test/test.container-definition.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed piradeepk’s stale review August 19, 2019 21:29

Pull request has been modified.

@iamhopaul123 iamhopaul123 force-pushed the additional_missing_unit_test branch from e36a366 to f1ee254 Compare August 19, 2019 22:28
@mergify mergify bot dismissed piradeepk’s stale review August 19, 2019 22:49

Pull request has been modified.

piradeepk
piradeepk approved these changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@piradeepk piradeepk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking the time to add all of these tests.

@piradeepk piradeepk self-requested a review August 19, 2019 22:54
@mergify
Copy link
Contributor

mergify bot commented Aug 19, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit 98f131a into aws:master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piradeepk piradeepk Awaiting requested review from piradeepk

Assignees

@piradeepk piradeepk

Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamhopaul123 @piradeepk @NGL321